Update acm SDK to v1.42.0 and regenerate#109
Conversation
ack-prow
Bot
added
the
needs-ok-to-test
|
Hi @KyleBS. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
43eacf8 to
eff0b9c
Compare
|
/label release/minor |
ack-prow
Bot
added
the
release/minor
|
/ok-to-test |
ack-prow
Bot
added
ok-to-test
eff0b9c to
52c472f
Compare
Bumps github.com/aws/aws-sdk-go-v2/service/acm from v1.33.0 to v1.42.0 and regenerates against the latest code-generator. Regeneration-only, no new functionality. New CRD fields introduced by the v1.42.0 model: - spec.managedBy: server-set, create-only (not in UpdateCertificateOptions), and nil for all non-managed certificates. Marked is_immutable + compare.is_ignored (NOT late_initialize -- a late-init field that is routinely nil makes incompleteLateInitialization loop forever, so the controller never reaches ResourceSynced=True). - spec.options.export: server-defaulted but updatable. late_initialize so the unset value is populated (avoiding a false-delta Update loop) while remaining in the delta so genuine user changes still reconcile. AWS returns Export for public and imported certs, so late-init completes. - status.domainValidations[].httpRedirect and status.renewalSummary.domainValidationOptions[].httpRedirect are read-only status fields. ACME resources present in the v1.42.0 model are ignored via ignore.resource_names; controllers for them are added in a follow-up.
52c472f to
8e48343
Compare
|
@KyleBS: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KyleBS, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds AcmeEndpoint, AcmeExternalAccountBinding, and AcmeDomainValidation as ACK resources on top of the v1.42.0 ACM SDK (now in main). - Removes these three from ignore.resource_names and generates the controllers, CRDs, and helm artifacts. - EAB credentials (keyId + macKey) are fetched via GetAcmeExternalAccountBindingCredentials and written to a pre-existing, user-specified Secret; the non-sensitive keyID is surfaced in status. - Standardized tag support (TagResource/UntagResource/ListTagsForResource) for all three resources. EAB has no service-side update, so its sdkUpdate is a custom tag-only reconcile. - AcmeEndpoint.CertificateAuthority is is_immutable + compare.is_ignored to avoid churn on server-defaulted AllowedKeyAlgorithms (no late_initialize, which would risk the incompleteLateInitialization loop seen in aws-controllers-k8s#109). - e2e tests cover create/update/delete plus AWS-describe verification and tag assertions via acktest.tags.assert_equal_without_ack_tags. Addresses review feedback on aws-controllers-k8s#108 (tag support, e2e update ops, AWS-side verification, correct metadata).
Releasing changes: * #109
2 participants
Issue #, if available: N/A
Description of changes: Bumps github.com/aws/aws-sdk-go-v2/service/acm from v1.33.0 to v1.42.0 and regenerates against the latest code-generator. This is a regeneration-only change with no new functionality:
The ACME resources (AcmeEndpoint, AcmeExternalAccountBinding, AcmeDomainValidation) present in the v1.42.0 model are ignored via ignore.resource_names; the controllers for them are added in a follow-up PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.